From 7ee6d6fbe717d07ee6d530ae73677ab803348d75 Mon Sep 17 00:00:00 2001 From: MasterAcnolo <68693319+MasterAcnolo@users.noreply.github.com> Date: Wed, 7 Oct 2026 17:21:10 +0200 Subject: [PATCH] refactor: remove custom top bar feature from configuration and UI --- README.md | 2 -- app/ipcHandlers.js | 1 - app/windowManager.js | 2 +- config/config.default.json | 1 - public/index.html | 4 ++-- public/script/topbar.js | 33 +++++++++++++++-------------- server/helpers/buildArgs.helpers.js | 1 - 7 files changed, 20 insertions(+), 24 deletions(-) diff --git a/README.md b/README.md index edb65ea..af3c8e9 100644 --- a/README.md +++ b/README.md @@ -227,7 +227,6 @@ Freedom Loader can be configured either through the settings panel in the UI or "autoUpdate": true, "systemTray": true, "discordRPC": true, - "customTopBar": true, "autoCheckInfo": true, "addThumbnail": true, "addMetadata": true, @@ -252,7 +251,6 @@ Freedom Loader can be configured either through the settings panel in the UI or | `autoUpdate` | boolean | `true` | Enable automatic application updates | | `systemTray` | boolean | `false` | Allow app to minimize on close [EXPERIMENTAL] | | `discordRPC` | boolean | `true` | Enable Discord Rich Presence integration | -| `customTopBar` | boolean | `true` | Use custom application top bar | | `autoCheckInfo` | boolean | `true` | Automatically fetch video information on URL paste | | `addThumbnail` | boolean | `true` | Embed thumbnail in downloaded audio files | | `addMetadata` | boolean | `true` | Add metadata tags to downloaded files | diff --git a/app/ipcHandlers.js b/app/ipcHandlers.js index 06c94de..3c5512b 100755 --- a/app/ipcHandlers.js +++ b/app/ipcHandlers.js @@ -33,7 +33,6 @@ const FEATURE_WHITELIST = new Set([ "autoUpdate", "systemTray", "discordRPC", - "customTopBar", "autoCheckInfo", "addThumbnail", "addMetadata", diff --git a/app/windowManager.js b/app/windowManager.js index a21ed42..ee30b8f 100644 --- a/app/windowManager.js +++ b/app/windowManager.js @@ -57,7 +57,7 @@ async function createMainWindow() { height: 800, minWidth: 750, minHeight: 800, - frame: !configFeatures.customTopBar, + frame: false, // Force custom topbar for consistent UI across platforms, and less maintenance headaches with native titlebar actions devTools: !app.isPackaged, show: false, webPreferences: { diff --git a/config/config.default.json b/config/config.default.json index 7fc2998..da7c960 100644 --- a/config/config.default.json +++ b/config/config.default.json @@ -2,7 +2,6 @@ "autoUpdate": true, "systemTray": false, "discordRPC": true, - "customTopBar": true, "autoCheckInfo": true, "addThumbnail": true, "addMetadata": true, diff --git a/public/index.html b/public/index.html index 1d50e1d..e9180b0 100644 --- a/public/index.html +++ b/public/index.html @@ -179,13 +179,13 @@ -
+
diff --git a/public/script/topbar.js b/public/script/topbar.js index c8ad591..e2a601d 100644 --- a/public/script/topbar.js +++ b/public/script/topbar.js @@ -35,25 +35,26 @@ export function initTopBar() { } -async function attachListeners(){ - try{ - const featuresList = await window.electronAPI.getFeatures(); +//* Disabled because i disabled native topbar for now, but keeping the code in case i want to re-enable it later +// async function attachListeners(){ +// try{ +// const featuresList = await window.electronAPI.getFeatures(); - if (!featuresList.customTopBar) { - const topbar = document.getElementById("topbar"); - const container = document.getElementById("container"); - const themeSwitcher = document.getElementById("theme-switcher"); +// if (!featuresList.customTopBar) { +// const topbar = document.getElementById("topbar"); +// const container = document.getElementById("container"); +// const themeSwitcher = document.getElementById("theme-switcher"); - if (topbar) topbar.style.display = "none"; - if (container) container.style.marginTop = "0"; - if (themeSwitcher) themeSwitcher.style.top = "30px"; - } +// if (topbar) topbar.style.display = "none"; +// if (container) container.style.marginTop = "0"; +// if (themeSwitcher) themeSwitcher.style.top = "30px"; +// } - } catch (error) { - console.error("Failed to load layout features for topbar:", error); - } +// } catch (error) { +// console.error("Failed to load layout features for topbar:", error); +// } -} +// } initTopBar() -document.addEventListener("DOMContentLoaded", attachListeners) \ No newline at end of file +//document.addEventListener("DOMContentLoaded", attachListeners) \ No newline at end of file diff --git a/server/helpers/buildArgs.helpers.js b/server/helpers/buildArgs.helpers.js index 75ad30f..806cc95 100644 --- a/server/helpers/buildArgs.helpers.js +++ b/server/helpers/buildArgs.helpers.js @@ -69,7 +69,6 @@ function buildYtDlpArgs({url, audioOnly, quality, outputFolder, isPlaylist}) { logger.info(`CONFIG autoUpdate: ${configFeatures.autoUpdate}`); logger.info(`CONFIG discordRPC: ${configFeatures.discordRPC}`); - logger.info(`CONFIG customTopBar: ${configFeatures.customTopBar}`); logger.info(`CONFIG autoCheckInfo: ${configFeatures.autoCheckInfo}`); logger.info(`CONFIG keepPlaylistOrder: ${configFeatures.keepPlaylistOrder}`); logger.info(`CONFIG addThumbnail: ${configFeatures.addThumbnail}`);