From e541eb442a6b75b73ef29e3c22f552aab46c84a9 Mon Sep 17 00:00:00 2001
From: MasterAcnolo <axel.ncls@hotmail.com>
Date: Wed, 9 Sep 2026 09:21:11 +0200
Subject: [PATCH] fix: - replace unusued throw new Error by logger.error -
 remove unusued variables isWindows, err - remove unusued logFormat - remove
 unusued imports logSessionEnd

---
 app/discordRPC.js                    | 2 +-
 app/pathValidator.js                 | 2 +-
 main.js                              | 2 +-
 server/controller/info.controller.js | 4 ++--
 server/logger.js                     | 5 -----
 server/server.js                     | 2 +-
 server/services/download.services.js | 2 +-
 7 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/app/discordRPC.js b/app/discordRPC.js
index 9bd1beb..6dfcbb3 100644
--- a/app/discordRPC.js
+++ b/app/discordRPC.js
@@ -102,7 +102,7 @@ function startRPC() {
 
   });
 
-  rpc.login({ clientId }).catch(err => {
+  rpc.login({ clientId }).catch(() => {
     // Since 1.6.2, it no longer print the error. This is because if discord is not opened, it will send an error.
     // logger.error("Unable to connect to the RPC:", err);
     logger.info("Unable to connect to the Discord RPC. Discord is maybe not launched");
diff --git a/app/pathValidator.js b/app/pathValidator.js
index db39cfd..1bb6546 100644
--- a/app/pathValidator.js
+++ b/app/pathValidator.js
@@ -66,7 +66,7 @@ function validateDownloadPath(userPath) {
       const real = fs.realpathSync(absolutePath);
 
       if (!isSafePath(real)) {
-        throw new Error("Path not allowed: system folders are blocked!");
+          logger.error("Path not allowed: system folders are blocked!");
       }
 
       return real;
diff --git a/main.js b/main.js
index c30a7e8..2b4dda4 100644
--- a/main.js
+++ b/main.js
@@ -74,7 +74,7 @@ const { updateYtDlp } = require("./app/ytDlpUpdater");
 const { createMainWindow, getMainWindow } = require("./app/windowManager");
 const { registerIpcHandlers } = require("./app/ipcHandlers");
 const { createSplashWindow, closeSplashWindow, setSplashProgress } = require("./app/splashManager");
-const { userThemesPath, initUserThemes, isWindows, validateBinaries, defaultDownloadFolder } = require("./server/helpers/path.helpers");
+const { userThemesPath, initUserThemes, validateBinaries, defaultDownloadFolder } = require("./server/helpers/path.helpers");
 const {createSystemTray, destroyTray} = require("./app/tray");
 const { stopServer } = require("./server/server");
 
diff --git a/server/controller/info.controller.js b/server/controller/info.controller.js
index 6e94598..ebe2a26 100644
--- a/server/controller/info.controller.js
+++ b/server/controller/info.controller.js
@@ -77,11 +77,11 @@ async function infoController(req, res) {
                     );
 
                     // Preserve original error context
-                    throw err;
+                    logger.error(err);
                 }
 
             } else {
-                throw err;
+                logger.error(err);
             }
         }
 
diff --git a/server/logger.js b/server/logger.js
index 7867c4d..0908bae 100644
--- a/server/logger.js
+++ b/server/logger.js
@@ -17,11 +17,6 @@ try {
   console.error(`Failed to create log directory: ${error.message}`);
 }
 
-const logFormat = format.combine(
-  format.timestamp({ format: "YYYY-MM-DD HH:mm:ss" }),
-  format.printf(({ timestamp, level, message }) => `${timestamp} | ${level.toUpperCase()} |  ${message}`)
-);
-
 /**
  * Format used by the saved file
  * @type {Format}
diff --git a/server/server.js b/server/server.js
index d4bc9a3..0ef6b81 100644
--- a/server/server.js
+++ b/server/server.js
@@ -2,7 +2,7 @@ const express = require("express");
 const path = require("path");
 const config = require("../config");
 
-const { logger, logSessionEnd } = require("./logger");
+const {logger} = require("./logger");
 const { rateLimit } = require("./helpers/rateLimit.helpers");
 
 const app = express();
diff --git a/server/services/download.services.js b/server/services/download.services.js
index 9bb33c4..1a39893 100644
--- a/server/services/download.services.js
+++ b/server/services/download.services.js
@@ -65,7 +65,7 @@ function createPlaylistFolder(basePath, playlistTitle) {
     }
 
     logger.error(`Could not find available playlist folder after 1000 attempts`);
-    throw new Error("Unable to create playlist folder");
+    logger.error("Unable to create playlist folder");
 
   } catch (err) {
     logger.warn(`Failed to create playlist folder with title "${sanitizedTitle}": ${err.message}`);