Compare commits

..

2 Commits

Author SHA1 Message Date
MasterAcnolo
ac1d74ff23 fix(autoUpdate): better error handling in frontEnd
#50
2026-09-27 21:19:48 +02:00
copilot-swe-agent[bot]
7f86d46ae7 fix: validate backend bug report configuration before request
Co-authored-by: MasterAcnolo <68693319+MasterAcnolo@users.noreply.github.com>
2026-09-27 18:31:59 +00:00
2 changed files with 21 additions and 65 deletions

View File

@@ -45,13 +45,32 @@ async function initUpdateUI() {
return; return;
} }
btn.onclick = () => { const initialButtonText = btn.textContent;
window.electronAPI.downloadUpdate(); const initialIconText = icon.textContent;
const initialTitleText = title.textContent;
const initialSubText = sub.textContent;
btn.onclick = async () => {
btn.disabled = true; btn.disabled = true;
btn.textContent = "Downloading..."; btn.textContent = "Downloading...";
icon.textContent = "download"; icon.textContent = "download";
title.textContent = "Downloading update"; title.textContent = "Downloading update";
progressWrap.style.display = "flex"; progressWrap.style.display = "flex";
try {
await window.electronAPI.downloadUpdate();
} catch {
btn.disabled = false;
btn.textContent = initialButtonText;
icon.textContent = initialIconText;
title.textContent = initialTitleText;
sub.textContent = initialSubText;
progressWrap.style.display = "none";
progressFill.style.width = "0%";
progressPct.textContent = "0%";
progressEta.textContent = "";
}
}; };
window.electronAPI.onDownloadProgress((progress) => { window.electronAPI.onDownloadProgress((progress) => {

View File

@@ -1,63 +0,0 @@
jest.mock("../../server/logger", () => ({
logger: {
info: jest.fn(),
warn: jest.fn(),
error: jest.fn(),
},
logDir: null,
}));
const { sendReport } = require("../../app/sendReport");
describe("sendReport", () => {
const originalEnv = { ...process.env };
beforeEach(() => {
jest.clearAllMocks();
process.env.BUG_REPORT_URL = "";
process.env.BUG_REPORT_API_KEY = "";
global.fetch = jest.fn();
});
afterAll(() => {
process.env = originalEnv;
});
test("throws a clear error when backend bug report config is missing", async () => {
await expect(
sendReport({
title: "Bug title",
description: "Bug description",
includeLogs: "no",
}),
).rejects.toThrow(
"Bug report service is not configured. Missing BUG_REPORT_URL or BUG_REPORT_API_KEY on backend.",
);
expect(global.fetch).not.toHaveBeenCalled();
});
test("sends request from backend when bug report config is present", async () => {
process.env.BUG_REPORT_URL = "https://example.com/report";
process.env.BUG_REPORT_API_KEY = "safe-test-key";
global.fetch.mockResolvedValue({ ok: true });
await expect(
sendReport({
title: "Bug title",
description: "Bug description",
includeLogs: "no",
}),
).resolves.toBe(true);
expect(global.fetch).toHaveBeenCalledWith(
"https://example.com/report",
expect.objectContaining({
method: "POST",
headers: {
"X-Api-Key": "safe-test-key",
},
}),
);
});
});