fix:

- replace unusued throw new Error by logger.error
- remove unusued variables isWindows, err
- remove unusued logFormat
- remove unusued imports logSessionEnd

server/controller/info.controller.js

@@ -77,11 +77,11 @@ async function infoController(req, res) {
                     );
 
                     // Preserve original error context
-                    throw err;
+                    logger.error(err);
                 }
 
             } else {
-                throw err;
+                logger.error(err);
             }
         }
 

server/logger.js

@@ -17,11 +17,6 @@ try {
   console.error(`Failed to create log directory: ${error.message}`);
 }
 
-const logFormat = format.combine(
-  format.timestamp({ format: "YYYY-MM-DD HH:mm:ss" }),
-  format.printf(({ timestamp, level, message }) => `${timestamp} | ${level.toUpperCase()} |  ${message}`)
-);
-
 /**
  * Format used by the saved file
  * @type {Format}

server/server.js

@@ -2,7 +2,7 @@ const express = require("express");
 const path = require("path");
 const config = require("../config");
 
-const { logger, logSessionEnd } = require("./logger");
+const {logger} = require("./logger");
 const { rateLimit } = require("./helpers/rateLimit.helpers");
 
 const app = express();

server/services/download.services.js

@@ -65,7 +65,7 @@ function createPlaylistFolder(basePath, playlistTitle) {
     }
 
     logger.error(`Could not find available playlist folder after 1000 attempts`);
-    throw new Error("Unable to create playlist folder");
+    logger.error("Unable to create playlist folder");
 
   } catch (err) {
     logger.warn(`Failed to create playlist folder with title "${sanitizedTitle}": ${err.message}`);